Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aerosol optical depth to AerosolState #567

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Add aerosol optical depth to AerosolState #567

merged 1 commit into from
Feb 14, 2025

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Feb 10, 2025

This PR adds aerosol optical depth to AerosolState.

@szy21, can you please let me know if this looks like I'm on the right track, or if there are changes needed here?

@szy21
Copy link
Member

szy21 commented Feb 10, 2025

Yes, this looks like the right direction. We only need the vertical sum of AOD though, not every layer. And I think if you could output AOD in this test: https://github.com/CliMA/RRTMGP.jl/blob/main/test/all_sky_with_aerosols_utils.jl, it would be a good step towards having it in ClimaAtmos.

@charleskawczynski
Copy link
Member Author

@sriharshakandala, can you please take a look at this?

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 12, 2025

pseudocode

    band_wv_550nm = 1 / band_550nm
    bandidx = 0
    for i in 1:nband
        if bnd_lims_wn[1, i] <= band_wd_550nm <= bnd_lims_wn[2, i]
            bandidx = i
            break
         end
    end

@szy21 szy21 force-pushed the ck/aod branch 7 times, most recently from 13a0467 to 28f12c8 Compare February 14, 2025 21:47
@charleskawczynski
Copy link
Member Author

I'm fine with incrementing the minor version in this PR, too. cc @szy21

@szy21
Copy link
Member

szy21 commented Feb 14, 2025

I'm fine with incrementing the minor version in this PR, too. cc @szy21

Oh, right, I forgot to do it.

@szy21 szy21 merged commit 9a0887a into main Feb 14, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants